Fix sync issues between tests #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bryanjtc you might be interested in this! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #404 +/- ##
==========================================
+ Coverage 92.05% 93.72% +1.66%
==========================================
Files 15 15
Lines 277 271 -6
Branches 72 70 -2
==========================================
- Hits 255 254 -1
+ Misses 22 17 -5 ☔ View full report in Codecov by Sentry. |
Closed
So the solution was to cleanup the error listeners after each use? |
This was referenced Nov 27, 2023
Merged
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #62
This PR introduces changes that finally fixes sync issues between failing stories. There are no leaks anymore. Thank god.
📦 Published PR as canary version:
0.15.3--canary.404.6dbd144.0✨ Test out this PR locally via:
npm install @storybook/test-runner@0.15.3--canary.404.6dbd144.0 # or yarn add @storybook/test-runner@0.15.3--canary.404.6dbd144.0Version
Published prerelease version:
v0.15.3-next.3Changelog
🐛 Bug Fix
jest-playwright-presetfromv3.0.1tov4.0.0#400 (@kemuridama)Authors: 4